[MAINNET] Reduces EIP-1559 denominator 250 -> 50 #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
0x00101010
previously approved these changes
May 15, 2025
xenoliss
commented
May 15, 2025
| **Override**: `0x0000000000000000000000000000000000000000000000000000000000000001` <br/> | ||
| **Meaning**: Override the threshold to 1 so the transaction simulation can occur. | ||
|
|
||
| - **Key**: `0xb2e9994c6b31ed56228de129778956be15269b0c7c0536d91dd4772660ea897a` <br/> |
There was a problem hiding this comment.
The key here will change as it corresponds to the slot associated with your signer address.
cb-heimdall
dismissed
0x00101010’s stale review
Approved review 2845112778 from 0x00101010 is now dismissed due to new commit. Re-request for approval.
jackchuma
reviewed
May 15, 2025
| > [!CAUTION] | ||
| > | ||
| > Before signing, ensure the below hashes match what is on your ledger. | ||
| > |
There was a problem hiding this comment.
Suggested change
| > | |
| > | |
| > ### Incident Safe - Mainnet: `0x14536667Cd30e52C0b458BaACcB9faDA7046E056` | |
| > |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step to address the calldata pricing issue by reducing the EIP-1559 denominator value, effectively steepening the base fee increase.