Add stats mp upload part copy#1214
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
What are these {t, {ok, ... bindings for?
Contributor
Author
There was a problem hiding this comment.
Sorry, I have to be serious :)
{t,_} is matched in catch clause right below to respond 400. There might be other error patterns because there was {t3,_} at https://github.com/basho/riak_cs/pull/1214/files#diff-d617e0da6709d2bb3eabf098f392f035L277.
Anyway, these diff lines are just by refactoring and not essential for this PR/commit.
Contributor
|
Code looks good and clean; Another pull requests merge made this branch conflicting, I'll +1 after rebase. |
added 2 commits
August 24, 2015 16:12
Fixed bugs - Handling of copy source that starts with multiple slashes - Handling of copy source that does not include key part - Respond with 404 when source is not found - Remove unused branch in catch and remove unsed function
shino
force-pushed
the
bugfix/stats-mp-copy
branch
from
d433fca to
18f2fba
Compare
Contributor
Author
|
Thanks for notification! Rebased on current develop 9519ff5 and force pushed. |
borshop
added a commit
that referenced
this pull request
Aug 24, 2015
Add stats mp upload part copy Reviewed-by: kuenishi
Contributor
Author
|
@borshop merge |
Contributor
|
See RCS-11 for release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add item missed at #1180 (RCS-220)