Skip to content

Make fold_objects the default in Riak CS#737

Merged
reiddraper merged 1 commit into
developfrom
feature/fold-objects-list-keys-default
Jan 30, 2014
Merged

Make fold_objects the default in Riak CS#737
reiddraper merged 1 commit into
developfrom
feature/fold-objects-list-keys-default

Conversation

@reiddraper
Copy link
Copy Markdown
Contributor

No description provided.

@reiddraper
Copy link
Copy Markdown
Contributor Author

I think this would be nice to have in 1.5, and should be easy. It's unlikely users will have a fresh install of Riak CS, but Riak < 1.4.0. Agree?

@kuenishi
Copy link
Copy Markdown
Contributor

Agree. Though we'll need some notes in release notes.

@reiddraper
Copy link
Copy Markdown
Contributor Author

Ready for some review here.

@andrewjstone
Copy link
Copy Markdown
Contributor

Looks good to me. Running tests.

@andrewjstone
Copy link
Copy Markdown
Contributor

  • eunit + eqc
  • riak_test

👍

reiddraper added a commit that referenced this pull request Jan 30, 2014
…ault

Make fold_objects the default in Riak CS
@reiddraper reiddraper merged commit 02e539c into develop Jan 30, 2014
@reiddraper reiddraper deleted the feature/fold-objects-list-keys-default branch January 30, 2014 18:30
@shino
Copy link
Copy Markdown
Contributor

shino commented Jan 31, 2014

Some more changes needed?

  • The default value FOLD_OBJECTS_FOR_LIST_KEYS in list_objects.hrl
  • Adding custom config to list_objects_test.erl.
    Current list_objects_v2_test.erl has its own custom setting
    {cs, rtcs:cs_config([{fold_objects_for_list_keys, true}])}

I will make PR of those. Please tell me if there are any others.

@reiddraper
Copy link
Copy Markdown
Contributor Author

I will make PR of those. Please tell me if there are any others.

Thanks, yeah I forgot those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants