Conversation
There was a security issue that flaws remaining multipart uploads,
where an newly created bucket may include unaborted or uncompleted
multipart uploads which was created in previous epoch of the bucket
with same name. This commit fixes it by:
- on creating buckets;
- check if live multipart exists
- if exists, return 500 failure to client
- on deleting buckets;
- try to clean up all live multipart remains
- check if live multipart remains (in stanchion)
- if exists, return 409 failure to client
- after upgrading from 1.4.x (or former) to 1.5.0;
- run `riak_cs_console:cleanup_orphan_multipart/0` or
`riak_cs_console:cleanup_orphan_multipart/1` in an
attached console to cleanup all buckets
- there might be a time period until above cleanup
finished, where no client can create bucket if
unfinished multipart upload remains under deleted
bucket. You can find [critical] log if such bucket
creation is attempted.
This commit also inclues:
- cut out bucket related operations from riak_cs_utils to riak_cs_bucket
- riak_test (riak_cs_buckets_test) to check bucket related tests
This was referenced May 14, 2014
Contributor
|
@kuenishi dialyzer emitted some warnings. PLT cleanup needed? |
Contributor
Author
|
Yeah, we made it dirty again. |
Contributor
|
all riak_test passed. |
Contributor
|
+1 1447cc3 |
borshop
added a commit
that referenced
this pull request
May 16, 2014
…hed-rebased Ensure no mp uploads remaining in bucket creation and deletion Reviewed-by: shino
Contributor
Author
|
@borshop merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(rebased version of #856)
There was a security issue that flaws remaining multipart uploads,
where an newly created bucket may include unaborted or uncompleted
multipart uploads which was created in previous epoch of the bucket
with same name. This commit fixes it by:
riak_cs_console:cleanup_orphan_multipart/0orriak_cs_console:cleanup_orphan_multipart/1in anattached console to cleanup all buckets
finished, where no client can create bucket if
unfinished multipart upload remains under deleted
bucket. You can find [critical] log if such bucket
creation is attempted.
This commit also inclues: