Skip to content

Is the doc for payment wrong #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
moecasts opened this issue Dec 25, 2018 · 10 comments
Closed

Is the doc for payment wrong #19

moecasts opened this issue Dec 25, 2018 · 10 comments
Assignees
Labels
good issue Good for newcomers help wanted Extra attention is needed

Comments

@moecasts
Copy link
Contributor

According to the doc, User model use CanBePaid trait, Item use hasWallet trait. I think it should be swapt. Such as User model use hasWallet trait, Item use CanBePaid trait.

@rez1dent3 rez1dent3 self-assigned this Dec 25, 2018
@rez1dent3 rez1dent3 added help wanted Extra attention is needed good issue Good for newcomers labels Dec 25, 2018
@rez1dent3
Copy link
Member

@moecasts I will consider replacing in the next versions, thank you

@moecasts
Copy link
Contributor Author

@rez1dent3 I read the code just now, I think User model use CanPay trait is a good choice.

@rez1dent3
Copy link
Member

@moecasts this week I will collect the test version and let you know

@moecasts
Copy link
Contributor Author

@rez1dent3 Thank you for your work. I will looking forward it.

rez1dent3 added a commit that referenced this issue Dec 25, 2018
rez1dent3 added a commit that referenced this issue Dec 25, 2018
@rez1dent3
Copy link
Member

@moecasts check PR #20, pls. All right?

@rez1dent3 rez1dent3 pinned this issue Dec 25, 2018
@moecasts
Copy link
Contributor Author

@rez1dent3 I think there should be a CanBePaid/CanBePaidFloat trait for Item instead of hasWallet.

@rez1dent3
Copy link
Member

@moecasts I'll think about it. Maybe I will. Thank you. Is PR #20 okay?

@moecasts
Copy link
Contributor Author

@rez1dent3 Yes, it's okay.

rez1dent3 added a commit that referenced this issue Dec 26, 2018
#19 add CanPay/CanPayFloat
@rez1dent3
Copy link
Member

@moecasts update docs ;)

PS,
This issue will not be closed until I make a decision on the trait for the goods.

@moecasts
Copy link
Contributor Author

@rez1dent3 I appreciate for your update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants