Skip to content

Conversation

@dcarp
Copy link
Collaborator

@dcarp dcarp commented Oct 11, 2025

  • Add the bazelrc-preset.bzl dependency to MODULE.bazel to support generation of the preset file.
  • Update CI workflow and buildifier steps to use the new Bazel configuration preset by switching to --config=ci for Bazel commands, ensuring CI-specific flags are applied.
  • Upgrade some bzlmod dependencies.

@dcarp dcarp force-pushed the use-bazelrc-preset branch from b5d1eb4 to 9c67493 Compare October 11, 2025 14:16
@dcarp dcarp requested a review from Copilot October 11, 2025 14:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project to use the bazelrc-preset.bzl module for standardized Bazel configuration management, replacing scattered configuration flags with a centralized preset system.

  • Adds bazelrc-preset.bzl dependency to generate comprehensive Bazel configuration presets
  • Updates CI workflows to use --config=ci flag for consistent CI-specific settings
  • Upgrades several bzlmod dependencies to newer versions

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/preset.bazelrc Generated comprehensive Bazel configuration preset with CI-specific flags
tools/BUILD.bazel Adds bazelrc_preset target for configuration generation
e2e/smoke/.bazelrc Migrates to import preset configuration, removes duplicate flags
MODULE.bazel Adds bazelrc-preset.bzl dependency and upgrades other dependencies
.github/workflows/ci.yaml Updates CI to use --config=ci flag
.github/workflows/ci.bazelrc Removes dedicated CI bazelrc file (replaced by preset)
.github/workflows/buildifier.yaml Updates buildifier to use --config=ci flag
.bazelversion Updates Bazel version from 7.6.1 to 7.6.2
.bazelrc Migrates to import preset configuration, removes duplicate flags

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dcarp dcarp merged commit 28b434f into bazel-contrib:main Oct 11, 2025
11 checks passed
@dcarp dcarp deleted the use-bazelrc-preset branch October 11, 2025 14:34
@dcarp dcarp restored the use-bazelrc-preset branch October 11, 2025 21:17
@dcarp dcarp deleted the use-bazelrc-preset branch October 11, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant