Skip to content

Conversation

@dcarp
Copy link
Collaborator

@dcarp dcarp commented Oct 11, 2025

No description provided.

@dcarp dcarp requested a review from Copilot October 11, 2025 21:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces shell-based testing with native binary testing to fix Windows build compatibility issues. The change removes the dependency on rules_shell and simplifies the test execution by using Bazel's native_test rule instead of sh_test.

  • Replaced sh_test with native_test for cross-platform compatibility
  • Removed the rules_shell dependency from MODULE.bazel
  • Simplified test configuration by eliminating the need for shell script generation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
d/tests/simple_as_binary/BUILD.bazel Updated test rule from sh_test to native_test and simplified configuration
MODULE.bazel Removed rules_shell dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dcarp dcarp merged commit 73f2cd8 into bazel-contrib:main Oct 11, 2025
17 checks passed
@dcarp dcarp deleted the fix-windows-build branch October 11, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant