Use CC toolchain for linking #132
Conversation
Use `find_cpp_toolchain` from bazel_tools to find the current cc toolchain and use the compiler from it for linking. This is a bit naive, since we might need to add more flags to it. But it seems to be enough with the local toolchain from rules_cc.
Try to be smarter about linking: use the cc_toolchain to get the linking flags, filter some flags out and then pass the result to the D compiler. This works slightly better, allowing to use `toolchains_llvm` bazel module.
|
Thank you for the PR.
I think this would be the right approach! Also, please rename the branch to something containing |
I'm not completely sure. From the rules_cc PoV it's likely the right thing to do, since otherwise extracting out the bits we need out of cc_toolchain definition is tricky. OTOH, I see some issues with that:
Uh, I didn't know CI triggers based on the branch name :) I will. I'd have to create a new PR for it though, right? |
|
Opened #133 (almost the same, just another branch name + empty line added to make buildifier happy) |
This to reduces the CI resources consumption. |
2 participants
There are two commits:
CCvariable to whatever the toolchain says is the compiler binary. This is clearly not enough for all cases, for example this doesn't work withtoolchains_llvmfor me.None of them are perfect, since the compiler options have to be filtered, also I haven't yet tested if it works on all platforms and whether cross-compilation works (not sure if it worked before this PR though, probably not).
Maybe we invert the direction here and instead of trying to give D compiler the correct way to call CC, try to link using the standard
cc_common.linkaction, adding the standard D libraries to the inputs.