Skip to content

Conversation

@dcarp
Copy link
Collaborator

@dcarp dcarp commented Sep 14, 2025

Add compatibility_proxy_repo of rules_cc-0.2.0 or newer.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dcarp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues with newer versions of rules_cc by upgrading the dependency to version 0.2.0 and integrating the required compatibility_proxy_repo. Additionally, it introduces bazel_features as a new dependency, which is essential for the updated rules_cc setup. The changes ensure that the build system remains functional and can leverage the latest rules_cc features.

Highlights

  • rules_cc Version Update: The rules_cc dependency has been updated from version 0.0.17 to 0.2.0 in the e2e/smoke/WORKSPACE.bazel file, including updates to its SHA256 hash and download URL.
  • Bazel Features Dependency: A new dependency on bazel_features has been introduced. This includes adding a bazel_dep in MODULE.bazel for version 1.28.0 and configuring its http_archive and bazel_features_deps() call in e2e/smoke/WORKSPACE.bazel for version 1.32.0.
  • Compatibility Proxy Integration: The compatibility_proxy_repo() function from rules_cc//cc:extensions.bzl has been added and invoked in e2e/smoke/WORKSPACE.bazel to ensure proper integration with rules_cc version 0.2.0 or newer.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the rules_cc dependency to version 0.2.0 for WORKSPACE-based setups, which also requires adding bazel_features as a new dependency. The changes look good and address the integration needs for the newer rules_cc. I've identified one high-severity issue regarding a version mismatch for bazel_features between the MODULE.bazel and WORKSPACE.bazel files, which should be aligned. I also have a medium-severity suggestion to improve the robustness of dependency fetching by adding a mirror URL. Overall, a good update to keep dependencies current.

@dcarp dcarp force-pushed the support-rules_cc-0.2.0+ branch from cb2f12b to d5f681b Compare September 14, 2025 15:01
@dcarp dcarp merged commit 42bb670 into bazel-contrib:main Sep 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant