-
-
Notifications
You must be signed in to change notification settings - Fork 22
Update repo structure to repo-template@6470c76 #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dcarp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the repository's Bazel build structure to align with a new template. The core changes involve centralizing package metadata and license definitions at the repository root, relocating the gazelle build tool to a dedicated tools directory, and updating the package_metadata dependency to a newer version. These changes streamline the build configuration and improve maintainability.
Highlights
- Bazel Build Configuration Refactoring: The
BUILD.bazelfile at the root has been updated to removegazelleandgazelle_binarydefinitions, instead introducingpackage_metadataandlicenserules. This centralizes the definition of package metadata and licensing information. - Gazelle Tool Relocation: The
gazellebuild tool has been moved from the rootBUILD.bazelto a newtools/BUILD.bazelfile. Correspondingly, theCONTRIBUTING.mdfile has been updated to reflect the new command for runninggazelle. - Dependency Update and Module Configuration: The
MODULE.bazelfile now usespackage_metadataversion0.0.5(upgraded from0.0.2) and includes detailed comments regarding theversionandcompatibility_levelfields, setting the module version to an empty string for better registry compatibility. Thed/repositories.bzlfile also reflects thispackage_metadataversion update. - Package Metadata Path Adjustment: The
REPO.bazelfile has been modified to point thedefault_package_metadatato the root//:package_metadatatarget, aligning with the centralization ofpackage_metadatain the rootBUILD.bazelfile. Thed/BUILD.bazelfile no longer defines its ownpackage_metadata.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the repository structure to align with a template, which includes updating Bazel module definitions, dependencies, and file organization. The changes are well-structured and follow modern Bazel practices. I've added one comment regarding target ordering for improved maintainability.
006df15 to
3a0e754
Compare
3a0e754 to
89308e4
Compare
No description provided.