Skip to content

Conversation

@dcarp
Copy link
Collaborator

@dcarp dcarp commented Sep 18, 2025

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dcarp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the repository's Bazel build structure to align with a new template. The core changes involve centralizing package metadata and license definitions at the repository root, relocating the gazelle build tool to a dedicated tools directory, and updating the package_metadata dependency to a newer version. These changes streamline the build configuration and improve maintainability.

Highlights

  • Bazel Build Configuration Refactoring: The BUILD.bazel file at the root has been updated to remove gazelle and gazelle_binary definitions, instead introducing package_metadata and license rules. This centralizes the definition of package metadata and licensing information.
  • Gazelle Tool Relocation: The gazelle build tool has been moved from the root BUILD.bazel to a new tools/BUILD.bazel file. Correspondingly, the CONTRIBUTING.md file has been updated to reflect the new command for running gazelle.
  • Dependency Update and Module Configuration: The MODULE.bazel file now uses package_metadata version 0.0.5 (upgraded from 0.0.2) and includes detailed comments regarding the version and compatibility_level fields, setting the module version to an empty string for better registry compatibility. The d/repositories.bzl file also reflects this package_metadata version update.
  • Package Metadata Path Adjustment: The REPO.bazel file has been modified to point the default_package_metadata to the root //:package_metadata target, aligning with the centralization of package_metadata in the root BUILD.bazel file. The d/BUILD.bazel file no longer defines its own package_metadata.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the repository structure to align with a template, which includes updating Bazel module definitions, dependencies, and file organization. The changes are well-structured and follow modern Bazel practices. I've added one comment regarding target ordering for improved maintainability.

@dcarp dcarp force-pushed the update-rules-template branch from 006df15 to 3a0e754 Compare September 18, 2025 18:25
@dcarp dcarp force-pushed the update-rules-template branch from 3a0e754 to 89308e4 Compare September 18, 2025 18:32
@dcarp dcarp merged commit 4f5a31e into bazel-contrib:main Sep 18, 2025
11 checks passed
@dcarp dcarp deleted the update-rules-template branch September 19, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant