Revert back from attribute to rule transitions #4415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayconrod
approved these changes
Aug 26, 2025
Collaborator
jayconrod
left a comment
jayconrod
left a comment
There was a problem hiding this comment.
Sorry for the slow reply: was on vacation.
This partially reverts #3116 now that Bazel allows transitions on rules to read configurable attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Refactoring
What does this PR do? Why is it needed?
Partially reverts #3116, which is no longer necessary now that Bazel 7 and higher support configurable attributes with rule transitions. As a result, a top-level Go rule shares its configuration with that of the go_context and cgo_context targets it depend on. This unblocks switching to joint toolchain resolution for Go and C/C++ in a backwards-compatible way.
Which issues(s) does this PR fix?
Other notes for review