wrap_sdk: make root_files a string_keyed_label_dict #4419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** I'm trying to use an extension-generated repo as a wrapped sdk using `root_files`. I get a package load error similar to bazelbuild/bazel#19301. **Which issues(s) does this PR fix?** I saw in the comments (specifically bazelbuild/bazel#19301 (comment)) that this would probably work if `root_files` used a `string_keyed_label_dict` and, when I tried it locally it did. **Other notes for review** bazelbuild/bazel#19301
fmeum
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
I'm trying to use an extension-generated repo as a wrapped sdk using
root_files. I get a package load error similar to bazelbuild/bazel#19301.Which issues(s) does this PR fix?
I saw in the comments (specifically bazelbuild/bazel#19301 (comment)) that this would probably work if
root_filesused astring_keyed_label_dictand, when I tried it locally it did.Fixes #4418
Other notes for review
bazelbuild/bazel#19301