Skip to content

Revert "go_sdk: store SDK filenames and hashes in lockfile facts" #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

Revert "go_sdk: store SDK filenames and hashes in lockfile facts" #4432

merged 1 commit into from
Aug 25, 2025

Conversation

@fmeum
Copy link
Member

@fmeum fmeum commented Aug 25, 2025

Reverts #4393

The facts feature didn't get merged in time for Bazel 8.4.0 and without it this PR caused an eager fetch of the version list for the default SDK.

@fmeum fmeum enabled auto-merge (squash) August 25, 2025 04:56
@fmeum fmeum requested review from jayconrod and linzhp August 25, 2025 04:56
@fmeum fmeum merged commit 6d90ede into master Aug 25, 2025
4 checks passed
@fmeum fmeum deleted the revert-4393-facts branch August 25, 2025 05:32
@sfc-gh-dbieliaiev sfc-gh-dbieliaiev mentioned this pull request Sep 15, 2025
Closed
fmeum added a commit that referenced this pull request Oct 30, 2025
@fmeum
Reapply "go_sdk: store SDK filenames and hashes in lockfile facts" (#…
73c097e 
…4432)

This reverts commit 6d90ede.

Includes the following fixes:
* Adapted to the more limited facts API that actually got merged.
* Prefetching of SDK hashes is now performed on a best-effort basis so that otherwise airgapped builds that provide SDK hashes do not result in failures.
fmeum added a commit that referenced this pull request Oct 30, 2025
@fmeum
Reapply "go_sdk: store SDK filenames and hashes in lockfile facts" (#…
04bb04b 
…4432)

This reverts commit 6d90ede.

Includes the following fixes:
* Adapted to the more limited facts API that actually got merged.
* Prefetching of SDK hashes is now performed on a best-effort basis so that otherwise airgapped builds that provide SDK hashes do not result in failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linzhp linzhp Awaiting requested review from linzhp

@jayconrod jayconrod Awaiting requested review from jayconrod

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fmeum