Include blackbox tests in compilation_outputs group #4437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
added a commit
to sluongng/rules_go
that referenced
this pull request
Sep 4, 2025
There can be up to 3 compile actions for each go_test target. Add the 3rd missing archive, similar to bazel-contrib#4437.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
The PR makes external test archive included in
compilation_outputsoutput group. This is necessary because currently, e.g.,bazel build --output_groups=compilation_outputs //foo/bar:bar_testwon't build test files that havepackage bar_testin them.Other notes for review
Slack context