Skip to content

Conversation

@orf
Copy link
Contributor

@orf orf commented Sep 9, 2025

What type of PR is this?
Documentation

What does this PR do? Why is it needed?

The older versions specified in the documentation don't work with go_work, which leads to confusing errors

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @orf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the "bazel_dep" versions for "rules_go" and "gazelle" within the "bzlmod.md" documentation. The change ensures that the documented versions are compatible with "go_work", preventing confusing errors for users following the guide.

Highlights

  • Documentation Update: Updated "bazel_dep" versions for "rules_go" (from 0.39.1 to 0.57.0) and "gazelle" (from 0.31.0 to 0.45.0) in "docs/go/core/bzlmod.md". This resolves compatibility issues, especially with "go_work".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the versions of rules_go and gazelle in the bzlmod.md documentation, with the stated goal of fixing issues related to go_work support. While updating the documentation is a good idea, the proposed versions (0.57.0 for rules_go and 0.45.0 for gazelle) do not appear to be available on the Bazel Central Registry. This would cause user builds to fail. I have left specific comments with suggestions to use the latest valid versions from the BCR. Please verify and update the versions accordingly.

@fmeum fmeum merged commit a65c1ac into bazel-contrib:master Sep 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants