Fix pure mode detection #4470
Merged
Fix pure mode detection #4470
+86
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayconrod
approved these changes
Oct 6, 2025
fmeum
force-pushed
the
add_cgo
branch
2 times, most recently
from
3594db0 to
7b59c4d
Compare
fmeum
changed the title
Member
Author
|
@jayconrod Looks like my latest change fixes the bug as per #4447 (comment). I haven't been able to produce a test for this, the one I added also passes on master. I'm inclined to merge this anyway and add a test later if someone manages to create a reproducer. |
`go_proto_library`, `nogo`, and `stdlib` may use cgo and thus need the relevant attributes to detect the availability of a C++ toolchain.
jayconrod
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
go_proto_library,nogo, andstdlibmay use cgo and thus need the relevant attributes to detect the availability of a C++ toolchain.pureflag is turned off or the toolchain turns off cgo via a constraint.Which issues(s) does this PR fix?
Fixes #4447
Other notes for review