Add riscv64 into BAZEL_GOARCH_CONSTRAINTS
#4507
Merged
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Fix some Bazel matching issues on riscv64
Which issues(s) does this PR fix?
Fixes #4053
Other notes for review
The riscv64 architecture has been widely developed and adopted recently, and optimizing support for riscv64 is very meaningful as it can provide better riscv64 support for downstream users.
For example, when I was using
bazeldnf, due to some limitations in the current repository, I couldn't usebazeldnfdirectly. The specific reason is this: https://github.com/rmohr/bazeldnf/blob/main/bazeldnf/platforms.bzl. This depends on the current repository'sBAZEL_GOARCH_CONSTRAINTS, which currently lacks riscv64 support, so the riscv64 version of bazeldnf cannot be used directly. If this PR is merged and released, downstream users will be able to get good riscv64 support.A PR quite similar to this one is #3336. I think the situation with riscv64 is quite similar to that case. The Go upstream also provides good support for riscv64.
Other Info
Co-authored by: [email protected];