Skip to content

Conversation

@ffgan
Copy link
Contributor

@ffgan ffgan commented Nov 7, 2025

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Fix some Bazel matching issues on riscv64

Which issues(s) does this PR fix?

Fixes #4053

Other notes for review

The riscv64 architecture has been widely developed and adopted recently, and optimizing support for riscv64 is very meaningful as it can provide better riscv64 support for downstream users.

For example, when I was using bazeldnf, due to some limitations in the current repository, I couldn't use bazeldnf directly. The specific reason is this: https://github.com/rmohr/bazeldnf/blob/main/bazeldnf/platforms.bzl. This depends on the current repository's BAZEL_GOARCH_CONSTRAINTS, which currently lacks riscv64 support, so the riscv64 version of bazeldnf cannot be used directly. If this PR is merged and released, downstream users will be able to get good riscv64 support.

A PR quite similar to this one is #3336. I think the situation with riscv64 is quite similar to that case. The Go upstream also provides good support for riscv64.

Other Info
Co-authored by: [email protected];

@fmeum fmeum enabled auto-merge (squash) November 7, 2025 08:45
@fmeum fmeum merged commit 3fe89b8 into bazel-contrib:master Nov 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No matching toolchains found for types @io_bazel_rules_go//go:toolchain

2 participants