Import tools/build_defs/repo/jvm.bzl from Bazel #299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dropping plans for this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This facilitates maven_jar migration, because jvm_maven_import_external's API is closer to maven_jar than rules_jvm_external.
By bringing it into rules_jvm_external, we can also decouple the release process from Bazel.
I imported it into the same tree location at
//tools/build_defs/repo:jvm.bzlto simplify migration:s/bazel_tools/rules_jvm_external/.There's no automated syncing between upstream Bazel and this file, but the file doesn't change too frequent anyway.