Skip to content

feat(uv): handle credential helpers and .netrc #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented May 11, 2025

This allows one to download the uv binaries from private mirrors.

The plumbing of the auth attrs allows us to correctly use the ~/.netrc
or the credential helper for downloading from mirrors that require
authentication.

Testing notes:

  • When I tested this, it seems that the dist manifest json may not work
    with private mirrors, but I think it is fine for users in such cases
    to define the uv srcs using the urls attribute.

Work towards #1975.

@aignas aignas requested a review from rickeylev as a code owner May 11, 2025 06:07
@aignas aignas marked this pull request as draft May 12, 2025 00:33
@aignas
Copy link
Collaborator Author

aignas commented May 12, 2025

Marking as draft because of what I've found during testing. This may need some extra polishing before it is ready.

@aignas
Copy link
Collaborator Author

aignas commented May 24, 2025

Decided to mark as ready for review since solving the dist-manifest issue may be more work.

@aignas aignas marked this pull request as ready for review May 24, 2025 15:42
This allows one to download the uv binaries from private mirrors.

Work towards bazel-contrib#1975.
@aignas aignas force-pushed the fix/1975/uv-auth branch from 0fc459d to 08d42e5 Compare May 28, 2025 13:53
@aignas aignas requested a review from rickeylev May 28, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants