Skip to content

fix(pypi): correctly aggregate the requirements files #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(pypi): correctly aggregate the requirements files #2932

wants to merge 1 commit into from

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented May 24, 2025 •
edited
Loading

This implements the actual fix where we are aggregating the whls correctly from
multiple different requirements lines.

TODO:

  • Add a test for sdists, which would be certainly duplicated.
  • Ask people to test.

Fixes #2648.
Closes #2658.

@aignas aignas force-pushed the fix/parse-requirements-overlapping branch from 8935418 to 1e4e8bf Compare May 28, 2025 13:49
@aignas aignas mentioned this pull request May 28, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev will be requested when the pull request is marked ready for review rickeylev is a code owner

@groodt groodt Awaiting requested review from groodt groodt will be requested when the pull request is marked ready for review groodt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

experimental_index_url can only be used in one pip.parse(), subsequent calls fail
1 participant
@aignas