maven_jar dependencies no longer work, as of #523

[iphydf]

#523 broke dependencies on jars with macros (scalactic, scala-logging, shapeless, scalatest). I'm using maven_jar and for the dependencies that have macros, I use @the_dependency//jar:file. That no longer works, because :file doesn't have JavaInfo. Removing :file makes the compiler fail. What's the new recommended way of importing e.g. scalatest?

[johnynek]

I guess that since CI is green and so are Stripes repos that you have set up your own bind for scalatest? The answer is that you need to point to a scala_import target and it should probably export scalactic or use the same set up that the rules are using in scala_repositories.

[ittaiz]

2 options: 1. Have a scala_import target which in its “jars” attribute has the //:file 2. Use scala_maven_import_external

…

On Sun, 22 Jul 2018 at 3:20 P. Oscar Boykin ***@***.***> wrote: I guess that since CI is green and so are Stripes repos that you have set up your own bind for scalatest? The answer is that you need to point to a scala_import target and it should probably export scalactic or use the same set up that the rules are using in scala_repositories. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#565 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIF6J7HweH4Dr_FoN4JdDSVa91yJm0ks5uI8U4gaJpZM4VZxnv> .