Skip to content

WORKSPACE recipe in README.md does not work with Bazel 1.0 #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
t-soliduslink opened this issue Nov 14, 2019 · 2 comments
Closed

WORKSPACE recipe in README.md does not work with Bazel 1.0 #876

t-soliduslink opened this issue Nov 14, 2019 · 2 comments

Comments

@t-soliduslink
Copy link

README.md points to commit 69d3c5b which is just before's Irina Iancu's commit 3404be0 which replaced java_common.create_provider with JavaInfo(). Bazel 1.0 removed java_common.create_provider (see Release Notes)

So people who just copy&paste the recipe will experience a build failure.

@ittaiz
Copy link
Contributor

ittaiz commented Nov 16, 2019 via email

@liucijus
Copy link
Collaborator

liucijus commented Mar 1, 2021

Seems to be solved by #1022

@liucijus liucijus closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants