Is it correct that rules_scala supports all minor versions of 2.11/2.12?

[Jamie5]

NOTE: I don't actually care about support for 2.11.0-2.11.8, this is more a question of policy and documentation (which does claim it's supported). For example should the below be fixed (assuming it is indeed a real error), or is the officially supported versions reduced to exclude these versions, or is every minor version except the latest 1 or 2 minor versions of 2.11/2.12 just a best-effort support only?

Using scala_test in 2.11.0-2.11.8 seems to fail with

scalac error: bad option: '-Ypartial-unification'
  scalac -help  gives more information
one error found
java.lang.RuntimeException: Build failed
	at io.bazel.rulesscala.scalac.ScalacProcessor.compileScalaSources(ScalacProcessor.java:246)
	at io.bazel.rulesscala.scalac.ScalacProcessor.processRequest(ScalacProcessor.java:69)
	at io.bazel.rulesscala.worker.GenericWorker.runPersistentWorker(GenericWorker.java:45)
	at io.bazel.rulesscala.worker.GenericWorker.run(GenericWorker.java:111)
	at io.bazel.rulesscala.scalac.ScalaCInvoker.main(ScalaCInvoker.java:41)
Target //:test failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 0.727s, Critical Path: 0.24s
INFO: 1 process: 1 worker.
FAILED: Build did NOT complete successfully

This is with

WORKSPACE

workspace(name = "com_rubrik_sdmain")

load(
    "@bazel_tools//tools/build_defs/repo:http.bzl",
    "http_archive",
    "http_jar",
    "http_file",
)

# bazel-skylib 0.8.0 released 2019.03.20 (https://github.com/bazelbuild/bazel-skylib/releases/tag/0.8.0)
skylib_version = "0.8.0"
http_archive(
    name = "bazel_skylib",
    type = "tar.gz",
    url = "https://github.com/bazelbuild/bazel-skylib/releases/download/{}/bazel-skylib.{}.tar.gz".format (skylib_version, skylib_version),
    sha256 = "2ef429f5d7ce7111263289644d233707dba35e39696377ebab8b0bc701f7818e",
)

# Setup rules scala https://github.com/scaledata/rules_scala
rules_scala_version = "71f06b97f2f79204e21519ee1aec84e4e46c3587"

http_archive(
    name = "io_bazel_rules_scala",
    sha256 = "7b2a293071b34f59a8847b3987432a772e66c19f61389f6cf1269f075d80c4e7",
    strip_prefix = "rules_scala-%s" % rules_scala_version,
    type = "zip",
    url = "https://github.com/scaledata/rules_scala/archive/%s.zip" % rules_scala_version,
)

load("@io_bazel_rules_scala//scala:scala.bzl", "scala_repositories")

load("@io_bazel_rules_scala//scala:toolchains.bzl", "scala_register_toolchains")
scala_register_toolchains()

scala_repositories((
    "2.11.0",
    {
        "scala_compiler": "d50dbbcc5fd79179fbe43c77560495c03c3193c38fc3ec9298802de67338d424",
        "scala_library": "3b19a2edb72292395182be38c864eda51432bed38496065ce51d2e466a97dfa6",
        "scala_reflect": "277af1255660f53cebd705b15badadff041a278f0d0c5bc5cfa3b1e03e9cabcf",
    },
))

BUILD.bazel

load("@io_bazel_rules_scala//scala:scala.bzl", "scala_library", "scala_binary", "scala_test")

scala_test(
    name = "test",
    srcs = ["B.scala"]
)

B.scala (don't think this matters)

class B

[ittaiz]

IMHO we should support the last two minors and the others are on a best effort like you mention.
If contributors will come with a specific need and will put up effort to ease this support (for example CI resources to test a version they can’t move from) then we should definitely consider it

[Jamie5]

Makes sense to me, is it worth updating README.md to something other than Rules scala supports all minor versions of Scala 2.11/2.12?

[ittaiz]

Sure. Want to send a PR for that?

On Tue, 28 Jan 2020 at 22:56 Jamie5 ***@***.***> wrote: Makes sense to me, is it worth updating README.md to something other than Rules scala supports all minor versions of Scala 2.11/2.12? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#966>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKQQFYWGAQPRQYK567I4Y3RACLX3ANCNFSM4KMYKJGQ> .

-- *Ittai Zeidman* 40 Hanamal street, Tel Aviv, Israel <http://www.wix.com>

[Jamie5]

Filed #969