Specs2 toolchain #1136
Merged
Specs2 toolchain #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simuons
reviewed
Nov 12, 2020
test_version/WORKSPACE.template
Outdated
| @@ -47,6 +47,8 @@ specs2_junit_repositories() | |||
|
|
|||
| register_toolchains("@io_bazel_rules_scala//testing:testing_toolchain") | |||
|
|
|||
| register_toolchains("@io_bazel_rules_scala//testing:testing_toolchain") | |||
There was a problem hiding this comment.
Thanks for catching!
simuons
reviewed
Nov 12, 2020
| deps_id = "specs2_classpath", | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| "@io_bazel_rules_scala_org_specs2_specs2_common", |
There was a problem hiding this comment.
Why all other deps are in form //external:io_bazel_rules_scala/dependency/... and these are not?
There was a problem hiding this comment.
It comes from the existing code: https://github.com/bazelbuild/rules_scala/blob/master/specs2/BUILD#L9
It's binded later in https://github.com/bazelbuild/rules_scala/blob/master/specs2/specs2.bzl#L26
Existing binds are subject to be removed later. Currently the goal is to give a way to not use binds.
ittaiz
approved these changes
Nov 13, 2020
docs/testing.md
Outdated
| ``` | ||
|
|
||
| ### Example to set up JUnit dependencies | ||
| ### Configuring JUnit dependencies vai toolchain |
There was a problem hiding this comment.
thanks for catching - fixed
ittaiz
approved these changes
Nov 13, 2020
blorente
pushed a commit
to twitter-forks/rules_scala
that referenced
this pull request
Nov 26, 2020
* Update testing docs, toolchain and repository loading * Add testing toolchain to version tests WORKSPACE * specs2 and specs2 junit toolchain deps * Use external name in toolchain helpers * Update and add specs2 docs and examples * Docs update * Remove duplicate toolchain registration * Move example workspace tests to a separete Travis CI job * Fix typo in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs2 toolchain, part of #940