Skip to content

Improve scala_config() documentation in README.md #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

kolotyluk
Copy link
Contributor

Description

Per #1490 improve README.md

Motivation

As a documentation wonk, I like documentation to minimize mistakes, and following the original documentation led to some copy/paste mistakes that had to be cleared up in the issues.

When I figure out how to support Scala 3, I will update the documentation again with a better explanation.

@google-cla
Copy link

google-cla bot commented Apr 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kolotyluk
Copy link
Contributor Author

CLA has been signed now...

@liucijus
Copy link
Collaborator

liucijus commented Apr 7, 2023

@googlebot I signed it!

@liucijus
Copy link
Collaborator

liucijus commented Apr 7, 2023

CLA has been signed now...

Still failing, @kolotyluk could you check if you have signed with the same email as your commits were made?

@kolotyluk
Copy link
Contributor Author

Google Identity Management is broken. There is no possible way in their UI to correct the information. I will have to contact them.

@kolotyluk
Copy link
Contributor Author

I spent a fair bit of time with Google One support trying to sort out the problem... Next, follow up with more specialized people at Google...

@kolotyluk
Copy link
Contributor Author

It seems that Google CLA does not work on Firefox... I have resubmitted via Chrome... Hopefully this works...

@kolotyluk
Copy link
Contributor Author

Updated CLA with my GitHub identity.

Copy link
Collaborator

@liucijus liucijus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kolotyluk!

@liucijus liucijus merged commit 69c91a9 into bazel-contrib:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants