Skip to content

Bind toolchains to Scala version #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

aszady
Copy link
Contributor

@aszady aszady commented Apr 2, 2024

Description

Use target_settings to indicate which Scala version is supported by the toolchain. This will become useful when multiple toolchains for each Scala version are defined.

The choice of toolchains to cover by this (first) migration is quite arbitrary, but should be enough to enable the basic cross-build use cases.

No change in behavior if the default Scala version is used.

Motivation

Originally #1290.
Partitioned from #1552.

@aszady aszady requested review from liucijus and simuons as code owners April 2, 2024 10:53
Use `target_settings` to indicate which Scala version is supported by the toolchain.
This will become useful when multiple toolchains for each Scala version are defined.

The choice of toolchains to cover by this (first) migration is quite arbitrary,
but should be enough to enable the basic cross-build use cases.

Co-authored-by: mkuta <[email protected]>
Copy link
Collaborator

@liucijus liucijus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aszady!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants