Semanticdb clear dir

.gitignore

@@ -9,4 +9,5 @@ hash2
 .metals
 .vscode
 unformatted-*.backup.scala
-.scala-build
+.scala-build
+test/semanticdb/tempsrc

src/java/io/bazel/rulesscala/scalac/ScalacWorker.java

@@ -38,7 +38,10 @@ public void work(String[] args) throws Exception {
     CompileOptions ops = new CompileOptions(args);
 
     Path outputJar = Paths.get(ops.outputName);
+
     Path workdir = ensureEmptyWorkDirectory(outputJar, ops.currentTarget);
+    ensureEmptySemanticDBDirectory(outputJar, ops.currentTarget);
+
     Path classes = Files.createDirectories(workdir.resolve("classes"));
     Path sources = Files.createDirectories(workdir.resolve("sources"));
 
@@ -95,6 +98,15 @@ private static Path ensureEmptyWorkDirectory(Path output, String label) throws I
 
     return Files.createDirectories(dir);
   }
+
+  private static void ensureEmptySemanticDBDirectory(Path output, String label) throws IOException {
+    String base = label.substring(label.lastIndexOf(':') + 1);
+    Path dir = output.resolveSibling("_semanticdb").resolve(base);
+
+    if (Files.exists(dir)) {
+      deleteRecursively(dir);
+    }   
+  }
 
   private static String[] collectSrcJarSources(
       String[] files, List<File> scalaJarFiles, List<File> javaJarFiles) {

test/semanticdb/BUILD

@@ -32,7 +32,7 @@ toolchain(
 
 scala_library(
     name = "all_lib",
-    srcs = glob(["**/*.scala"]),
+    srcs = glob(["*.scala"]),
 )
 
 semanticdb_vars_script(
@@ -49,3 +49,13 @@ semanticdb_vars_script(
     name = "semantic_provider_vars_empty",
     dep = "empty_lib",
 )
+
+scala_library(
+    name = "lib_with_tempsrc",
+    srcs = glob(
+        [
+            "*.scala",
+            "tempsrc/*.scala",  #Include src files that are dynamically generated by the test_semanticdb.sh (tmpsrc should be in .gitignore so its contents don't get checked in)
+        ],
+    ),
+)

test/shell/test_semanticdb.sh

@@ -134,10 +134,51 @@ test_no_semanticdb() {
   fi
 }
 
+
+test_semanticdb_handles_removed_sourcefiles() {
+  #Ensure absense of bug where bazel failed with 'access denied' on Windows when a source file was removed.
+
+  #First add the new scala file, build it, then remove the new scala file, and ensure it builds.
+  set -e
+
+  local toolchainArg=--extra_toolchains=//test/semanticdb:semanticdb_nobundle_toolchain
+  local newfile_dir=test/semanticdb/tempsrc
+  local newfilename=D.scala
+  local newfilepath=$newfile_dir/$newfilename
+  local rule_label=//test/semanticdb:lib_with_tempsrc
+
+  #add new source file and build it
+  mkdir -p $newfile_dir && echo "class D{ val a = 1; }" > $newfilepath
+
+
+  #make sure D.scala was added to the target (sanity check)      
+  local query_result1=$(bazel query "labels(srcs, $rule_label)")
+  if [[ $query_result1 != *"$newfilename"* ]] ; then
+    echo "$newfilename was not properly added as src for target $rule_label"
+    exit 1
+  fi
+
+  bazel build $rule_label $toolchainArg
+
+  #remove the new source file and build it
+  rm $newfilepath
+
+  #make sure D.scala was properly removed from the target(sanity check)
+  local query_result2=$(bazel query "labels(srcs, $rule_label)")
+  if  [[ $query_result2 == *"$newfilename"* ]] ; then    
+    echo "$newfilename was not properly removed as src for target $rule_label"
+    exit 1
+  fi
+
+  bazel build $rule_label $toolchainArg
+
+
+}
+
 run_semanticdb_tests() {
   local bundle=1;   local nobundle=0
   local scala3=3;    local scala2=2
-
+  
   $runner test_produces_semanticdb $scala2 $bundle 
   $runner test_produces_semanticdb $scala2 $nobundle 
 
@@ -147,7 +188,7 @@ run_semanticdb_tests() {
   $runner test_produces_semanticdb $scala3 $nobundle 
 
   $runner test_no_semanticdb
-
+  $runner test_semanticdb_handles_removed_sourcefiles
 }
 
 run_semanticdb_tests