Create the @scala_compiler_sources repo
#1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains aliases to versioned Scala compiler source repository targets. Part of bazel-contrib#1482. Updates the version specific repo references in the srcs attribute of `//third_party/dependency_analyzer/src/main/io/bazel/rulesscala/dependencyanalyzer/compiler:dep_reporting_compiler`. Now these are references to versioned targets in `@scala_compiler_sources//`, which are aliases to those versioned compiler source repos. In a Bzlmod world, this enables `rules_scala` to import only the `scala_compiler_sources` repo in `MODULE.bazel`, instead of importing each individual versioned compiler source repo. This then allows `rules_scala` clients to set multiple `SCALA_VERSIONS` without requiring them to import this repo or any versioned compiler source repo. The Bzlmodifcation of the test repos under `dt_patches` (coming in a future change) revealed the need for this flexibility.
simuons
requested changes
Oct 25, 2024
| @@ -5,7 +5,9 @@ load("@io_bazel_rules_scala//scala:scala_cross_version.bzl", "version_suffix") | |||
| scala_library_for_plugin_bootstrapping( | |||
| name = "dep_reporting_compiler", | |||
| srcs = select({ | |||
There was a problem hiding this comment.
Since you are hiding/unifying version specific repositories under @scala_compiler_sources maybe this select should be moved into that repository. I mean @scala_compiler_sources would have a single alias target with select to version specific sources. For example:
alias(
name = "src",
visibility = ["//visibility:public"],
actual = select({"@io_bazel_rules_scala_config//:scala_version_2_12_19": "@scala_compiler_source_2_12_19//:src"}),
)
And here in compilation target you would specify srcs = ["@scala_compiler_sources//:src"],
What do you think?
Also I think that compilation target could go into that new repository, but let's not go down that rabbit hole now.
simuons
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contains aliases to versioned Scala compiler source repository targets. Part of #1482.
Updates the version specific repo references in the srcs attribute of
//third_party/dependency_analyzer/src/main/io/bazel/rulesscala/dependencyanalyzer/compiler:dep_reporting_compiler. Now these are references to versioned targets in@scala_compiler_sources//, which are aliases to those versioned compiler source repos.Motivation
In a Bzlmod world, this enables
rules_scalato import only thescala_compiler_sourcesrepo inMODULE.bazel, instead of importing each individual versioned compiler source repo.This then allows
rules_scalaclients to set multipleSCALA_VERSIONSwithout requiring them to import this repo or any versioned compiler source repo. The Bzlmodifcation of the test repos underdt_patches(coming in a future change) revealed the need for this flexibility.