Bump Scalafmt from 3.8.6 to 3.9.1 #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates `scripts/create_repository.py` to prevent `scala-collection-compat` versions from flipping on subsequent runs by no longer comparing Scala versions. Part of bazel-contrib#1482. Both Scalafmt and ScalaPB depend on `org_scala_lang_modules_scala_collection_compat`. Before removing the Scala version comparison, subsequent `create_repository.py` runs would flip between these two artifacts for Scala 3.3 through 3.6: - `org.scala-lang.modules:scala-collection-compat_2.13:2.13.0` - `org.scala-lang.modules:scala-collection-compat_3:2.12.0` The artifact with the higher release version number is preferable to the artifact with the higher Scala version. The change from `FileOps` to `PlatformFileOps` in `ScalafmtAdapter` is a consequence of an update first included in Scalafmt 3.9.0: - scalameta/scalafmt#4800 - scalameta/scalafmt@0bdbf03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also updates
scripts/create_repository.pyto preventscala-collection-compatversions from flipping on subsequent runs by no longer comparing Scala versions. Part of #1482.Both Scalafmt and ScalaPB depend on
org_scala_lang_modules_scala_collection_compat. Before removing the Scala version comparison, subsequentcreate_repository.pyruns would flip between these two artifacts for Scala 3.3 through 3.6:org.scala-lang.modules:scala-collection-compat_2.13:2.13.0org.scala-lang.modules:scala-collection-compat_3:2.12.0The artifact with the higher release version number is preferable to the artifact with the higher Scala version.
The change from
FileOpstoPlatformFileOpsinScalafmtAdapteris a consequence of an update first included in Scalafmt 3.9.0:Motivation
As with #1692, this is to ensure Scalafmt is as current as can be before landing Bzlmod and Bazel 8 compatibility changes.