don't put signatures in deploy jar

[oscar-stripe]

We hit some error with a jar including a signature, then it causing the deploy jar to fail verification.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[bazel-io]

Can one of the admins verify this patch?

[ittaiz]

test this please (cibot)

[ittaiz]

I think we should have a test for this change so it won't be broken by mistake in the future. We can even check in a small binary with a signature if that would make it easier. WDYT?

[ittaiz]

Do you think it would be wise to rename JarCreator to FatJarCreator / DeployJarCreator / UberJarCreator? Current name made me wonder why the override is like this and the base is just "false". Until I read the comment and remembered

[johnynek]

yeah, I will add a test. I just wanted to get unblocked so I pushed it here.

[ittaiz]

Sure. We can merge and you can add a test later if you're blocked. WDYT about the JarCreator class name (again not blocking the merge)?

…

On Wed, Jun 14, 2017 at 9:58 PM P. Oscar Boykin ***@***.***> wrote: yeah, I will add a test. I just wanted to get unblocked so I pushed it here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#229 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUIF1YzhB97IN-fC8gsYgFa0tBoFaJ8ks5sEC1RgaJpZM4N6R19> .

[johnynek]

okay @ittaiz, I have added a test which exposes the problem if I don't have this change and does not fail with the change.

I don't want to rename things at this stage since this code was originally copied from bazel and they set the names (also, we have code that actually depend on it elsewhere so it will be a migration pain for us that I am hoping to avoid).

[johnynek]

I consent

[ittaiz]

Test this please

[ittaiz]

LGTM