Skip to content

renamed MoreScala* targets to ResourcesStripScala* targets #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2017

Conversation

ittaiz
Copy link
Contributor

@ittaiz ittaiz commented Jun 18, 2017

Pretty confident from context and git commit log that this is the actual name.
I tried to understand this a few weeks ago and thought it's best to document this knowledge back in the code.
@johnynek,
Would appreciate your thoughts as well to make sure I'm not adding confusion here.

@ittaiz ittaiz requested a review from johnynek June 18, 2017 06:24
@ittaiz
Copy link
Contributor Author

ittaiz commented Jun 19, 2017

@johnynek wdyt?

@ittaiz ittaiz merged commit 2381281 into master Jun 20, 2017
@ittaiz ittaiz deleted the target_renames branch June 28, 2017 05:53
natansil pushed a commit to wix-incubator/rules_scala that referenced this pull request Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants