Skip to content

add 0.6.0 to travis #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2017
Merged

add 0.6.0 to travis #285

merged 2 commits into from
Sep 30, 2017

Conversation

johnynek
Copy link
Contributor

No description provided.

@johnynek
Copy link
Contributor Author

@damienmg looks like the osx box is in a bad state again.

@damienmg
Copy link
Contributor

/cc @katre maybe just turn off the slave until Monday?

@katre
Copy link

katre commented Sep 29, 2017

I fixed the darwin-x86_64-1 node.

@johnynek
Copy link
Contributor Author

@azymnis let's see if using workers can make a big impact. It should since most of the test examples are so small, the JIT'ed worker should really jam on it.

Also, since we actually use workers almost always internally, it is better to actually test with workers, in my view.

@johnynek
Copy link
Contributor Author

okay, using workers seems dramatically faster (shocker). This should help the timeouts @azymnis

After this is green, I'll merge, if you merge this in maybe it won't timeout.

@johnynek
Copy link
Contributor Author

@ittaiz what do you think?

@azymnis
Copy link
Contributor

azymnis commented Sep 29, 2017

@johnynek sure, I'll just merge this in my branch if that's ok

@johnynek
Copy link
Contributor Author

johnynek commented Sep 29, 2017 via email

@johnynek
Copy link
Contributor Author

@ittaiz is you merge this, can you do a regular merge? We now have two downstream PRs branching off this and doing a squash or rebase will complicate things there.

#286 and #281 are both using this to get a faster build.

@ittaiz ittaiz merged commit a5ed9ba into master Sep 30, 2017
@ittaiz ittaiz deleted the oscar/test-0_6_0 branch April 15, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants