Address inconsistent behavior of generated resources files #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
|
Can one of the admins verify this patch? |
|
👍 Will merge when green. |
johnynek
reviewed
Oct 5, 2017
| @@ -1 +1,8 @@ | |||
| exports_files(["byes", "hellos", "hellos-and-byes.jar", "more-byes", "more-hellos"]) | |||
|
|
|||
| genrule( | |||
There was a problem hiding this comment.
getting fancy: generated resources...
There was a problem hiding this comment.
Yeah admittedly this is a subtle corner case... We somehow still managed to hit it though
|
I restarted it. Yeah, the build is really slow. I tried to speed it up using workers. The clean is pretty expensive, also the bazel install is expensive. Happy to take any PRs on this. |
|
Also,
Resolving issue #76 will probably help some of this thanks to Bazel caching
…On Fri, 6 Oct 2017 at 1:47 P. Oscar Boykin ***@***.***> wrote:
Merged #297 <#297>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#297 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABUIF-smiU4wHOjAxWkN-SET3037N1wVks5spVyBgaJpZM4Pvo3r>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with issue #296