Support JMH for scala 2.12 #295 #463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
reviewed
Mar 31, 2018
| ) | ||
| System.exit(1) | ||
| } | ||
| val fs = FileSystems.getDefault | ||
|
|
||
| BenchmarkGeneratorArgs( | ||
| fs.getPath(argv(0)), | ||
| if ("asm".equalsIgnoreCase(argv(0))) AsmGenerator else ReflectionGenerator, |
There was a problem hiding this comment.
can we error if it is not asm or reflection?
| case _: ArrayIndexOutOfBoundsException => | ||
| // this would fail due to https://github.com/bazelbuild/rules_scala/issues/295 | ||
| // let's throw a useful message instead | ||
| sys.error("jmh in rules_scala doesn't work with Java 8 bytecode: https://github.com/bazelbuild/rules_scala/issues/295") |
There was a problem hiding this comment.
can we change the error to say asm mode does not work with java 8 bytecode and instead suggest using reflection?
|
Thank you so much for tackling this! This will be a big help. I think the 2.12 branch is a bit out of date sadly. For instance, I think it may have an out of date Can you make this as a PR against master and then we can cherry-pick it and re-enable the jmh test? If you do this, we can probably merge very quickly. |
|
Closing in favor of #465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use reflection-based generator (RFGeneratorSource) instead of ASM-based, it does support Java8 byte-code.
Also version of JMH is upgraded.