Skip to content

+ operator on a depset is forbidden #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2018
Merged

+ operator on a depset is forbidden #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scala_proto/scala_proto.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ def _colon_paths(data):

def _gen_proto_srcjar_impl(ctx):
acc_imports = []
transitive_proto_paths = depset()
transitive_proto_paths = []

proto_deps, jvm_deps = [], []
for target in ctx.attr.deps:
Expand All @@ -329,7 +329,7 @@ def _gen_proto_srcjar_impl(ctx):
acc_imports.append(target.proto.transitive_sources)
#inline this if after 0.12.0 is the oldest supported version
if hasattr(target.proto, 'transitive_proto_path'):
transitive_proto_paths += target.proto.transitive_proto_path
transitive_proto_paths.append(target.proto.transitive_proto_path)
else:
jvm_deps.append(target)

Expand All @@ -345,7 +345,7 @@ def _gen_proto_srcjar_impl(ctx):
# Command line args to worker cannot be empty so using padding
flags_arg = "-" + ",".join(ctx.attr.flags),
# Command line args to worker cannot be empty so using padding
packages = "-" + ":".join(transitive_proto_paths.to_list())
packages = "-" + ":".join(transitive_proto_paths)
)
argfile = ctx.actions.declare_file("%s_worker_input" % ctx.label.name, sibling = ctx.outputs.srcjar)
ctx.actions.write(output=argfile, content=worker_content)
Expand Down