Fix scalapb_proto_library doc #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the build failed specifically on Windows. Could someone restart the build to get it green? |
|
@johnynek bump - I don't think this build should be failing for any good reason, could you restart the build and ✅-> merge? |
|
#749 is really causing issues... we need to disable that CI. |
gergelyfabian
pushed a commit
to gergelyfabian/rules_scala
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #744.
Summary
This PR fixes docs for
scalapb_proto_libraryand adds a section onscala_proto_toolchain.For ease of review, the rendered Markdown.
Misc
loads inscala_proto.bzlscala_proto.bzl