Handle FileAlreadyExistsException in ScalaPBGenerator #787
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only "I consent." in this pull request. Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@sholokhov can you comment |
| @@ -39,7 +40,13 @@ class ScalaPBGenerator extends Processor { | |||
| val relativePath = root.relativize(fullPath) | |||
|
|
|||
| relativePath.toFile.getParentFile.mkdirs | |||
| Files.copy(fullPath, relativePath) | |||
| Try(Files.copy(fullPath, relativePath)) match { | |||
| case Failure(err) if err.isInstanceOf[FileAlreadyExistsException] => | |||
There was a problem hiding this comment.
nit: case Failure(err: FileAlreadyExistsException) => would be a bit less verbose.
| case Failure(err) if err.isInstanceOf[FileAlreadyExistsException] => | ||
| Console.println(s"File already exists, skipping: ${err.getMessage}") | ||
| case Failure(err) => | ||
| sys.error(err.getMessage) |
There was a problem hiding this comment.
nit, I would rethrow here: throw err
|
I consent. |
|
@johnynek given that he already said that, can I close this PR, and open a new one with me as the only author on the code as a way to satisfy that? |
workaround for #779