Skip to content

Fix action_should_fail_with_message does not exit 1 #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix action_should_fail_with_message does not exit 1 #860

wants to merge 1 commit into from

Conversation

borkaehw
Copy link
Contributor

@borkaehw borkaehw commented Oct 7, 2019

Description

action_should_fail_with_message should exit 1 if the action doesn't fail with the message.

Track the issue here: #855

Motivation

Intermediate step for test refactoring.

@borkaehw borkaehw requested a review from johnynek as a code owner October 7, 2019 16:59
@borkaehw borkaehw mentioned this pull request Oct 7, 2019
Closed
@simuons simuons mentioned this pull request Feb 2, 2021
Merged
@liucijus
Copy link
Collaborator

liucijus commented Feb 2, 2021

Solved via #1198

@liucijus liucijus closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnynek johnynek Awaiting requested review from johnynek

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borkaehw @liucijus @googlebot