Add rules_go 0.33.0 #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
rules-go-0.33.0
branch
4 times, most recently
from
3fbe8b5 to
43960d2
Compare
alexeagle
reviewed
Jun 9, 2022
|
This is cool -- what else is there to do to get this working? |
fmeum
force-pushed
the
rules-go-0.33.0
branch
2 times, most recently
from
fde55be to
8794b37
Compare
This is highly experimental and thus carries a `print` warning.
Contributor
Author
It should be working now :-) Once rules_go is in the registry, I will try to get my prototype integration for bazel-gazelle in, which should then allow rules_go to fetch the dependencies it needs for proto support. |
|
Amazing! Thanks so much for doing this. I wrote my own module for rules_go before I realised this PR was open and I feel a bit silly :) Looking forward to getting this merged and further additions to the BCR. |
Member
|
This is just awesome, thanks again @fmeum ! |
meteorcloudy
approved these changes
Jul 4, 2022
Contributor
Author
|
@meteorcloudy Is it possible that you forgot to hit the merge button? :) |
uhthomas
approved these changes
Jul 4, 2022
Member
Yes, sorry about that.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is highly experimental and thus carries a
printwarning.