Skip to content
This repository was archived by the owner on Aug 30, 2022. It is now read-only.

Migrate maven_jar to jvm_maven_import_external #159

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

jin
Copy link
Member

@jin jin commented Dec 2, 2019

This prepares the repo for Bazel 2.0.

Copy link
Member

@ittaiz ittaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!
Feel free to merge when the build is green

@ittaiz
Copy link
Member

ittaiz commented Dec 2, 2019

Looks like they’re not passing...
Can you take a look? If you can’t navigate there I’ll jump in.
I’m super swamped getting ready for my BazelCon talk next week...

@jin jin force-pushed the migrate-maven-jar branch 6 times, most recently from 4f8cd06 to 9f390bb Compare December 2, 2019 17:10
@jin jin force-pushed the migrate-maven-jar branch from 9f390bb to 7695174 Compare December 2, 2019 17:20
@jin
Copy link
Member Author

jin commented Dec 2, 2019

Green! I don't have permissions to merge, though.

@ittaiz
Copy link
Member

ittaiz commented Dec 2, 2019

I’m here

Copy link
Member

@ittaiz ittaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants