Skip to content

incompatible_require_linker_input_cc_api: Wrap Starlark C++ library objects with linker_input #10860

@oquenchil

Description

@oquenchil

This disables several Starlark C++ API method parameters and getters.

create_linking_context no longer accepts: libraries_to_link, user_link_flags and additional_inputs

linking_context no longer has the getters: libraries_to_link, user_link_flags and additional_inputs

Flag: --incompatible_require_linker_input_cc_api

This refactoring was necessary for the implementation of cc_shared_library. In order to reduce the surface of the API we are removing the old way of creating a linking context.

Migration
create_linker_input allows you to pass the same parameters that you were previously passing to create_linking_context: libraries_to_link, user_link_flags and additional_inputs

linking_context now has the getter linker_inputs. Each linker_input instance has all the getters that were removed from linking_context: libraries_to_link, user_link_flags and additional_inputs

Metadata

Metadata

Assignees

Labels

P2We'll consider working on this in future. (Assignee optional)incompatible-changeIncompatible/breaking changeteam-Rules-CPPIssues for C++ rules

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions