-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Closed
Labels
P2We'll consider working on this in future. (Assignee optional)We'll consider working on this in future. (Assignee optional)area-BzlmodBzlmod-specific PRs, issues, and feature requestsBzlmod-specific PRs, issues, and feature requeststeam-DocumentationDocumentation improvements that cannot be directly linked to other team labelsDocumentation improvements that cannot be directly linked to other team labelsteam-ExternalDepsExternal dependency handling, remote repositiories, WORKSPACE file.External dependency handling, remote repositiories, WORKSPACE file.type: documentation (cleanup)
Description
Page link:
https://bazel.build/external/extension
Problem description (include actual vs expected text, if applicable):
As is explained and motivated in #17564 (comment), module extensions are identified by the .bzl
file they are imported from instead of reference equality on the underlying module extension object. This is different behavior from most other concepts in Starlark and something that extension authors should be aware of. It would be helpful to document this fact in the Module extensions documentation.
Where do you see this issue? (include link to specific section of the page, if applicable)
This fact is not documented in https://bazel.build/external/extension#extension_definition as of now.
Any other information you'd like to share?
I will open a PR shortly with a proposed addition to the documentation.
Metadata
Metadata
Assignees
Labels
P2We'll consider working on this in future. (Assignee optional)We'll consider working on this in future. (Assignee optional)area-BzlmodBzlmod-specific PRs, issues, and feature requestsBzlmod-specific PRs, issues, and feature requeststeam-DocumentationDocumentation improvements that cannot be directly linked to other team labelsDocumentation improvements that cannot be directly linked to other team labelsteam-ExternalDepsExternal dependency handling, remote repositiories, WORKSPACE file.External dependency handling, remote repositiories, WORKSPACE file.type: documentation (cleanup)