[8.4.0] Overlay the registry MODULE.bazel file on the module repo

[iancha1992]

RELNOTES: Modules backed by http_archive or git_repository no longer require a MODULE.bazel file to be contained in the source archive.

Fixes #26217

Closes #26332.

PiperOrigin-RevId: 778139801
Change-Id: Ie1d219ce1c219c8bae7657be929e54b9b467abf9

Commit c5a562b

[meteorcloudy]

@fmeum PTAL

[fmeum]

@iancha1992 This patch should fix the test:

diff --git a/src/test/py/bazel/bzlmod/mod_command_test.py b/src/test/py/bazel/bzlmod/mod_command_test.py
index f032bbc1ae..5915e6724e 100644
--- a/src/test/py/bazel/bzlmod/mod_command_test.py
+++ b/src/test/py/bazel/bzlmod/mod_command_test.py
@@ -476,9 +476,9 @@ class ModCommandTest(test_base.TestBase):
     stdout.pop(44)
     self.assertRegex(stdout.pop(49), r'^  urls = \[".*"\],$')
     self.assertRegex(stdout.pop(49), r'^  integrity = ".*",$')
-    self.assertRegex(stdout.pop(53), r'^  remote_module_file_urls = \[".*"\],$')
+    self.assertRegex(stdout.pop(52), r'^  remote_module_file_urls = \[".*"\],$')
     self.assertRegex(
-        stdout.pop(53), r'^  remote_module_file_integrity = ".*",$'
+        stdout.pop(52), r'^  remote_module_file_integrity = ".*",$'
     )
     # lines after '# Rule http_archive defined at (most recent call last):'
     stdout.pop(13)
@@ -545,8 +545,8 @@ class ModCommandTest(test_base.TestBase):
             '  strip_prefix = "",',
             '  remote_file_urls = {},',
             '  remote_file_integrity = {},',
-            # pop(53) -- remote_module_file_urls=[...]
-            # pop(53) -- remote_module_file_integrity=...
+            # pop(52) -- remote_module_file_urls=[...]
+            # pop(52) -- remote_module_file_integrity=...
             '  remote_patches = {},',
             '  remote_patch_strip = 0,',
             ')',

[iancha1992]

@iancha1992 This patch should fix the test:

diff --git a/src/test/py/bazel/bzlmod/mod_command_test.py b/src/test/py/bazel/bzlmod/mod_command_test.py
index f032bbc1ae..5915e6724e 100644
--- a/src/test/py/bazel/bzlmod/mod_command_test.py
+++ b/src/test/py/bazel/bzlmod/mod_command_test.py
@@ -476,9 +476,9 @@ class ModCommandTest(test_base.TestBase):
     stdout.pop(44)
     self.assertRegex(stdout.pop(49), r'^  urls = \[".*"\],$')
     self.assertRegex(stdout.pop(49), r'^  integrity = ".*",$')
-    self.assertRegex(stdout.pop(53), r'^  remote_module_file_urls = \[".*"\],$')
+    self.assertRegex(stdout.pop(52), r'^  remote_module_file_urls = \[".*"\],$')
     self.assertRegex(
-        stdout.pop(53), r'^  remote_module_file_integrity = ".*",$'
+        stdout.pop(52), r'^  remote_module_file_integrity = ".*",$'
     )
     # lines after '# Rule http_archive defined at (most recent call last):'
     stdout.pop(13)
@@ -545,8 +545,8 @@ class ModCommandTest(test_base.TestBase):
             '  strip_prefix = "",',
             '  remote_file_urls = {},',
             '  remote_file_integrity = {},',
-            # pop(53) -- remote_module_file_urls=[...]
-            # pop(53) -- remote_module_file_integrity=...
+            # pop(52) -- remote_module_file_urls=[...]
+            # pop(52) -- remote_module_file_integrity=...
             '  remote_patches = {},',
             '  remote_patch_strip = 0,',
             ')',

@fmeum Done! Thank you

[gholms]

How annoying would a 7 backport for this be?

[fmeum]

How annoying would a 7 backport for this be?

The backport itself should be fine.

@meteorcloudy What do you think of one more 7.x release closer to the Bazel 9 release?

[meteorcloudy]

What do you think of one more 7.x release closer to the Bazel 9 release?

SG, if this is actually doable, we can mark it as potential cherry pick for 7

[fmeum]

@bazel-io flag