Path map environment variable values #26609
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apart from threading through `PathMapper` to `getEffectiveEnvironment`, this required refactoring away the `envResolved` logic in `EnhancedStarlarkAction` and `ExtraAction`. Instead, `ActionSpawn` now always calls out to `getEffectiveEnvironment` to resolve the env, while giving subclasses of `SpawnAction` a chance to override it.
fmeum
requested review from
a team,
lberki,
comius,
pzembrod and
trybka
as code owners
github-actions
bot
added
team-Performance
|
@bazel-io fork 8.4.0 |
Nous5
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from threading through
PathMappertogetEffectiveEnvironment, this required refactoring away theenvResolvedlogic inEnhancedStarlarkActionandExtraAction. Instead,ActionSpawnnow always calls out togetEffectiveEnvironmentto resolve the env, while giving subclasses ofSpawnActiona chance to override it.RELNOTES: The values of environment variables are now subject to path mapping (if enabled for the action).