WIP: Rework Skyframe handling of external files #26892
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
26450-redo-external
branch
3 times, most recently
from
ab142f1 to
81a8e2f
Compare
All consumers transform the path into a root anyway, which makes this a useful refactoring in its own right. In follow-up work, this can be used to return a distinct `Root` per `RepositoryDirectoryValue`, even for the same underlying `Path`. This allows for clean invalidation of file state under a repository upon a refetch without injecting additional dependencies into `FileStateFunction`. Work towards bazelbuild#26450
This makes it possible to get rid of `RepositoryDirectoryDirtinessChecker` and all the infrastructure required to wire it up in the executor. The new `allowExternalRepositories` bit also replaces other such bits. # Conflicts: # src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryFetchFunction.java # src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDirectoryValue.java # Conflicts: # src/test/java/com/google/devtools/build/lib/bazel/repository/RepositoryDelegatorTest.java
# Conflicts: # src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryFetchFunction.java
fmeum
force-pushed
the
26450-redo-external
branch
from
81a8e2f to
0275bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.