Respect --xcode_version=/absolute/path above everything else #26901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In d2e8c82 we added support for setting --xcode_version to an absolute path. However, this logic is currently only exercised in certain conditions. For example, when no other copies of Xcode are available this option doesn't seem effective. This change moves the logic for checking whether the flag is set to an absolute path to the very top. While there, remove dubious initializations of xcode_version_properties and availability.
github-actions
bot
added
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In d2e8c82 we added support for setting --xcode_version to an absolute path. However, this logic is currently only exercised in certain conditions. For example, when no other copies of Xcode are available this option doesn't seem effective.
This change moves the logic for checking whether the flag is set to an absolute path to the very top. While there, remove dubious initializations of xcode_version_properties and availability.