Provide a Root instead of a Path on RepositoryDirectoryValue
#26907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested review from
lberki,
Wyverald and
meteorcloudy
as code owners
github-actions
bot
added
team-ExternalDeps
All consumers transform the path into a root anyway, which makes this a useful refactoring in its own right. In follow-up work, this can be used to return a distinct `Root` per `RepositoryDirectoryValue`, even for the same underlying `Path`. This allows for clean invalidation of file state under a repository upon a refetch without injecting additional dependencies into `FileStateFunction`. Work towards bazelbuild#26450
fmeum
force-pushed
the
26450-advertise-root
branch
from
2128b24 to
04010d1
Compare
Wyverald
approved these changes
Sep 5, 2025
Wyverald
added
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All consumers transform the path into a root. This also makes it easier to experiment with alternative approaches to invalidation of external repo files, such as returning distinct
Roots per fetch.Work towards #26450