remote: preserve lost action inputs#29548
Open
sluongng wants to merge 1 commit into
Open
Conversation
sluongng
force-pushed
the
sluongng/action-rewind-fix
branch
2 times, most recently
from
76fb7a3 to
a111d06
Compare
A Bazel 9.x remote spawn can fail with "Missing digest" during Merkle tree input upload and report a generic remote cache failure instead of a lost input. This happens because upload failures are de-duplicated by digest through casUploadCache, even though each caller can identify its current action's input for the missing digest. Mutating the shared failure would let concurrent same-digest waiters inherit another action's input. Keep shared upload failures digest/path-oriented and annotate CacheNotFoundExceptions while converting each UploadTask's completion into a TransferResult, using that subscriber's own retained exec path. BulkTransferException validates annotated paths against the current action resolver before reporting lost artifacts and continues skipping misses that action rewind cannot fix. This lets valid lost inputs drive action rewinding while avoiding misattribution when two actions upload the same digest concurrently, without retaining full ActionInput objects in upload tasks.
sluongng
force-pushed
the
sluongng/action-rewind-fix
branch
from
a111d06 to
070357c
Compare
github-actions
Bot
added
team-Remote-Exec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Bazel 9.x remote spawn can fail with "Missing digest" during Merkle
tree input upload and report a generic remote cache failure instead of
a lost input. This happens because upload failures are de-duplicated by
digest through casUploadCache, even though each caller can identify its
current action's input for the missing digest. Mutating the shared
failure would let concurrent same-digest waiters inherit another
action's input.
Keep shared upload failures digest/path-oriented and annotate
CacheNotFoundExceptions while converting each UploadTask's completion
into a TransferResult, using that subscriber's own retained exec path.
BulkTransferException validates annotated paths against the current
action resolver before reporting lost artifacts and continues skipping
misses that action rewind cannot fix.
This lets valid lost inputs drive action rewinding while avoiding
misattribution when two actions upload the same digest concurrently,
without retaining full ActionInput objects in upload tasks.