downloader: fix opaque file URI names#29549
Open
sluongng wants to merge 1 commit into
Open
Conversation
Fix a Bazel 9.1.0 regression where repository_ctx.download could crash on opaque file URIs such as file:../archive.tgz. The URL-to-URI migration changed basename extraction because URI.getPath() returns null for these inputs, unlike URL#getPath(). DownloadManager then passed null to PathFragment.create while building distdir candidate names. Reuse one basename helper for download destinations and distdir lookups, falling back to the scheme-specific part for opaque URIs. Add regression coverage for the explicit-output and typed-download paths. Fixes bazelbuild#29393.
github-actions
Bot
added
team-ExternalDeps
Wyverald
reviewed
May 19, 2026
| if (path == null && url.isOpaque()) { | ||
| // Match URL#getPath() behavior for opaque file URIs such as file:../archive.tgz. | ||
| String rawPath = url.getRawSchemeSpecificPart(); | ||
| if (rawPath != null) { |
Member
There was a problem hiding this comment.
according to https://docs.oracle.com/en/java/javase/25/docs//api/java.base/java/net/URI.html#getRawSchemeSpecificPart(), rawPath can never be null, so we can remove this if.
| path = | ||
| rawPath.isEmpty() | ||
| ? "" | ||
| : URI.create(url.getScheme() + ":" + rawPath).getSchemeSpecificPart(); |
Member
There was a problem hiding this comment.
I don't understand this line. Isn't this just equivalent to rawPath itself? In fact aren't lines 556-559 just saying path=rawPath?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a Bazel 9.1.0 regression where repository_ctx.download
could crash on opaque file URIs such as file:../archive.tgz. The
URL-to-URI migration changed basename extraction because URI.getPath()
returns null for these inputs, unlike URL#getPath(). DownloadManager
then passed null to PathFragment.create while building distdir
candidate names.
Reuse one basename helper for download destinations and distdir
lookups, falling back to the scheme-specific part for opaque URIs.
Add regression coverage for the explicit-output and typed-download
paths.
Fixes #29393.