Skip to content

Merge direct runtime jars, java constraints and JavaSourceInfoProvider in java_common.merge() #8847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Merge direct runtime jars, java constraints and JavaSourceInfoProvider in java_common.merge() #8847

wants to merge 3 commits into from

Conversation

iirina
Copy link
Contributor

@iirina iirina commented Jul 10, 2019 •
edited
Loading

Fixes #8916.

@iirina iirina added the WIP label Jul 10, 2019
@iirina iirina mentioned this pull request Jul 15, 2019
Merged
@iirina iirina force-pushed the java-info-merge-everything branch from 579382d to ded587d Compare September 12, 2019 18:44
@iirina iirina changed the title Merge direct runtime jars in java_common.merge() Merge direct runtime jars and JavaSourceInfoProvider in java_common.merge() Sep 12, 2019
@iirina iirina removed the WIP label Sep 12, 2019
@iirina iirina marked this pull request as ready for review September 12, 2019 20:03
@iirina iirina requested a review from hlopko as a code owner September 12, 2019 20:03
@iirina iirina added the team-Rules-Java Issues for Java rules label Sep 12, 2019
@iirina iirina changed the title Merge direct runtime jars and JavaSourceInfoProvider in java_common.merge() Merge direct runtime jars, java constraints and JavaSourceInfoProvider in java_common.merge() Sep 12, 2019
hlopko
hlopko approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in acdd365 Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlopko hlopko hlopko approved these changes

Assignees
No one assigned
Labels
cla: yes team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaInfo#runtime_output_jars not containing all the expected jars
3 participants
@iirina @hlopko @googlebot